feat(builtins): full sort -k KEYDEF parsing with multi-key support#920
Merged
feat(builtins): full sort -k KEYDEF parsing with multi-key support#920
Conversation
Parse the complete GNU sort key spec: start/end fields (-k2,3), character positions (-k2.3,3.4), per-key flags (-k2n,2 -k3r,3), and multiple keys for cascading sort priority. Closes #906
chaliy
force-pushed
the
feat/issue-906-sort-keydef
branch
from
669f91d to
3475813
Compare
-k2 now means "field 2 only" (same as -k2,2) instead of "field 2 to end of line". This matches existing test expectations and common usage patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-k KEYDEFparsing:START[.CHAR][FLAGS][,END[.CHAR][FLAGS]]-k2,3), character positions (-k2.3,3.4), per-key flags (-k2n,2), and multiple keys (-k1,1 -k2n)key_field: Option<usize>withVec<KeySpec>for multi-key cascading sortTest plan
cargo test --test spec_tests -- bash_spec_testspassessort_key_end_field,sort_key_numeric_per_key,sort_key_multiple,sort_key_reverse_per_key,sort_key_char_positioncargo clippy -- -D warningscleanCloses #906